-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Secrets SDK CI to work with MacOS ARM runners #2155
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for looking into this Timothy!
sudo rm -Rf /Library/Developer/CommandLineTools/SDKs/*; | ||
export CC=$(xcrun -f clang); | ||
export CXX=$(xcrun -f clang++); | ||
SYSROOT=$(xcrun --sdk macosx --show-sdk-path); | ||
export CFLAGS="-isysroot $SYSROOT -isystem $SYSROOT"; | ||
npm run build -- --target aarch64-apple-darwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not convenient that the pipeline broke, but at least we were able to remove these steps from the aarch64 build 😋
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2155 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 628 628
Lines 17891 17891
Branches 3755 3792 +37
=======================================
Hits 16319 16319
Misses 1571 1571
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
What It Does
Applies changes from napi-rs/package-template@299e2a6 so that x64 and ARM binaries for MacOS are built correctly now that
macos-latest
runner defaults to ARM architectureHow to Test
Review Checklist
I certify that I have:
Additional Comments